Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch example from using ImageNameSelector to ImageName #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Switch example from using ImageNameSelector to ImageName #112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
997d1b0
Switch example from using ImageNameSelector to ImageName
HunterGerlach Dec 8, 2023
ddd2050
Merge branch 'devfile:main' into docs/fix-outerloop-code-example
HunterGerlach Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions libs/docs/src/docs/2.2.1/innerloop-vs-outerloop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,14 +182,14 @@ The component and commands here allow the developer to build, run, debug, and te
### Procedure

1. Add an image component to define the image building process
1. Label your image tag with `imageNameSelector`
1. Label your image tag with `imageName`
2. Define your `dockerfile` with your file path, build context and if your build requires root privileges

```yaml
components:
- name: outerloop-build
image:
imageNameSelector: landingpage-image:latest
imageName: landingpage-image:latest
dockerfile:
uri: docker/Dockerfile
buildContext: .
Expand All @@ -212,7 +212,7 @@ The component and commands here allow the developer to build, run, debug, and te
components:
- name: outerloop-build
image:
imageNameSelector: landingpage-image:latest
imageName: landingpage-image:latest
dockerfile:
uri: docker/Dockerfile
buildContext: .
Expand Down Expand Up @@ -261,7 +261,7 @@ metadata:
components:
- name: outerloop-build
image:
imageNameSelector: landingpage-image:latest
imageName: landingpage-image:latest
dockerfile:
uri: docker/Dockerfile
buildContext: .
Expand Down
8 changes: 4 additions & 4 deletions libs/docs/src/docs/2.2.2/innerloop-vs-outerloop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,14 +182,14 @@ The component and commands here allow the developer to build, run, debug, and te
### Procedure

1. Add an image component to define the image building process
1. Label your image tag with `imageNameSelector`
1. Label your image tag with `imageName`
2. Define your `dockerfile` with your file path, build context and if your build requires root privileges

```yaml
components:
- name: outerloop-build
image:
imageNameSelector: landingpage-image:latest
imageName: landingpage-image:latest
dockerfile:
uri: docker/Dockerfile
buildContext: .
Expand All @@ -212,7 +212,7 @@ The component and commands here allow the developer to build, run, debug, and te
components:
- name: outerloop-build
image:
imageNameSelector: landingpage-image:latest
imageName: landingpage-image:latest
dockerfile:
uri: docker/Dockerfile
buildContext: .
Expand Down Expand Up @@ -261,7 +261,7 @@ metadata:
components:
- name: outerloop-build
image:
imageNameSelector: landingpage-image:latest
imageName: landingpage-image:latest
dockerfile:
uri: docker/Dockerfile
buildContext: .
Expand Down
Loading