Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devtools Week] Update contributing guide #113

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Dec 12, 2023

What does this PR do / why we need it

The PR updates the contributing guide and tries to align it with the registry-support & alizer ones in order to have consistent guides across the devfile organization.

Which issue(s) does this PR fix

fixes devfile/api#1350

PR acceptance criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

How to test changes / Special notes to the reviewer

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk changed the title Update contributing guide [Devtools Week] Update contributing guide Dec 15, 2023
@thepetk thepetk merged commit 1b9d9f5 into devfile:main Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and update devfile/devfile-web contributing guide
2 participants