-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecated stack filter on the registry-viewer and fix deprecated Color #122
Conversation
Will investigate too why the color of the |
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
a464ac6
to
9fdd935
Compare
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I was able to spin up the viewer after altering the registry to ensure there is a fully deprecated stack and can confirm the option is there and properly filters the stacks shown based on what box you tick. I also tried it without altering the registry and the options don't show up on the side as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Also tested against our test registry and verified that deprecated filter works as intended.
Looks good @thepetk!
Deprecated Stacks
Non-Deprecated Stacks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do / why we need it
This PR adds a filter inside the registry viewer so we can filter out deprecated or non deprecated stacks. A deprecated stack is considered when the
Deprecated
tag is added on the default version main tag section.Note that if all the stacks are deprecated or non-deprecated the filter is not appearing (this is the default configuration for our filters)
Example image:
An additional fix for this PR is the deprecated color. As it can be seen here the deprecated color is not visible.
The fix simply hardcodes the 2 cases of tag colors (following all other cases of style classes) so tailwind can load them when we run the project.
Which issue(s) does this PR fix
Fixes devfile/api#1064
PR acceptance criteria
Update the sidebar if there is a new file added or an existing filename is changed
How to test changes / Special notes to the reviewer
To test the changes someone should: