Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop using Che plugin registry for editor definitions #64

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

svor
Copy link
Collaborator

@svor svor commented Oct 15, 2024

What does this PR do?

  • Stop using che-plugin-registry URL to get editor definitions, instead it's possible to provide editorURL parameter
  • Add .devfile.yaml to develop on Che
  • Add LICENSE file
  • Update README
  • Add default extensions

What issues does this PR fix or reference?

eclipse-che/che#23187

Is it tested? How?

It could be tested by running it on Che instance using factory: Contribute (nightly)

And execute commands provided by devfile:

  • Build
  • Generate DevWorkspace with Template (it uses editorURL as a prameter)

As a result /tmp/devworkspace-che-code-latest.yaml should be generated

@svor svor self-assigned this Oct 15, 2024
@svor svor requested review from tolusha and ibuziuk as code owners October 15, 2024 16:50
@svor
Copy link
Collaborator Author

svor commented Oct 15, 2024

cc @musienko-maxim

@svor
Copy link
Collaborator Author

svor commented Oct 17, 2024

@olexii4 @RomanNikitenko FYI
che-dashboard and che-code may be affected when the devworkspace-generator version is updated

Copy link

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: svor, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit be04ded into main Oct 22, 2024
2 checks passed
@svor svor deleted the sv-remove-plugin-reg branch October 22, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants