-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Chart OpenShift Route Handling #238
Conversation
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small comments
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, johnmcollier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
Bug fix and small enhancement
What does does this PR do / why we need it:
This PR aims to address the issue that occurs when a user installs the
devfile registry
via Helm to an OpenShift environment. Prior to this change thefqdn
of theregistry-viewer
was not properly being set as it was expectingglobal.ingress.domain
to be set, but if you are installing to OpenShift it was not a requirement to set that.In order to solve this problem the following was added:
A helper script for OpenShift installations via Helm
fqdn
properly set if OpenShift auto generates a domain for you, or if you set a domain yourself. It utilizesHelm Upgrade
to mimic the functionality currently in place for theregistry operator
where thefqdn
is set after deployment (it spins up a new replacement pod after the information is known).Template updates
OpenShift Routes
andKubernetes Ingresses
.Updated documentation
devfile registry
with the use of a Helm chart.Which issue(s) this PR fixes:
Fixes devfile/api#1467
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
The following cases will result in the
fqdn
of theregistry-viewer
being properly set:The following case will result in the
fqdn
not being properly set: