Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dotnet80 stack #452

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

msivasubramaniaan
Copy link
Collaborator

What does this PR do?:

Added dotnet80 stack

Which issue(s) this PR fixes:

devfile/api#1540

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Signed-off-by: msivasubramaniaan <[email protected]>
@msivasubramaniaan msivasubramaniaan requested a review from a team as a code owner July 19, 2024 13:05
@openshift-ci openshift-ci bot requested review from elsony and michael-valdron July 19, 2024 13:05
Copy link

openshift-ci bot commented Jul 19, 2024

Hi @msivasubramaniaan. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stacks/dotnet80/devfile.yaml Outdated Show resolved Hide resolved
@Jdubrick
Copy link
Contributor

Who is going to be the stack owner of this new stack?

@msivasubramaniaan
Copy link
Collaborator Author

Who is going to be the stack owner of this new stack?

I am planning to own this stack and added the entry on https://github.com/devfile/registry/blob/main/.github/CODEOWNERS

@Jdubrick
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, we need to fix the CODEOWNERS file before merging (both fixing the handle and giving sufficient access to the codeowner).

.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: msivasubramaniaan <[email protected]>
@thepetk
Copy link
Contributor

thepetk commented Jul 23, 2024

Needs review from the @devfile/che-team too.

@michael-valdron michael-valdron requested a review from a team July 23, 2024 14:44
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion to use 2.2.2 schema version
screenshot-nimbusweb me-2024 07 23-18_12_48

stacks/dotnet80/devfile.yaml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jul 23, 2024
Signed-off-by: msivasubramaniaan <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Jul 23, 2024
@msivasubramaniaan msivasubramaniaan requested a review from svor July 23, 2024 16:00
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jul 23, 2024
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, msivasubramaniaan, svor, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 683aaad into devfile:main Jul 24, 2024
11 checks passed
@msivasubramaniaan msivasubramaniaan deleted the add-devfile-dotnet8 branch July 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants