added fastify server support #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivictbor
requested changes
Nov 1, 2024
There was a problem hiding this comment.
@SerVitasik great speed 💪, let's move common html snippet to file genericServer.ts both express server and fastify should extend the class from this file
ivictbor
approved these changes
Nov 8, 2024
| @@ -101,7 +59,7 @@ class ExpressServer implements IExpressHttpServer { | |||
| await proxyTo(`http://localhost:5173${req.url}`, res); | |||
| } catch (e) { | |||
| // console.log('Failed to proxy', e); | |||
| res.status(500).send(respondNoServer('AdminForth SPA is not ready yet', 'Vite is still starting up. Please wait a moment...')); | |||
| res.status(500).send(this.respondNoServer('AdminForth SPA is not ready yet', 'Vite is still starting up. Please wait a moment...')); | |||
There was a problem hiding this comment.
@SerVitasik I think the string literals should be moved as well.
| @@ -134,7 +92,7 @@ class ExpressServer implements IExpressHttpServer { | |||
| fileExists = false; | |||
| } | |||
| if (!fileExists) { | |||
| res.status(500).send(respondNoServer(`${this.adminforth.config.customization.brandName} is still warming up`, 'Please wait a moment...')); | |||
| res.status(500).send(this.respondNoServer(`${this.adminforth.config.customization.brandName} is still warming up`, 'Please wait a moment...')); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.