Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsl: better fix for custom coefficients on staggered grids #1640

Closed
wants to merge 7 commits into from

Conversation

EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Mar 23, 2021

Also fixes the issue where custom coefficients would not be applied to forward or backward timesteps

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1640 (7ca46ac) into master (4471237) will increase coverage by 0.01%.
The diff coverage is 98.47%.

❗ Current head 7ca46ac differs from pull request most recent head d295607. Consider uploading reports for the commit d295607 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
+ Coverage   86.48%   86.49%   +0.01%     
==========================================
  Files         216      216              
  Lines       32387    32606     +219     
  Branches     4280     4293      +13     
==========================================
+ Hits        28010    28203     +193     
- Misses       3892     3919      +27     
+ Partials      485      484       -1     
Impacted Files Coverage Δ
devito/core/gpu.py 94.53% <ø> (-0.12%) ⬇️
devito/symbolics/inspection.py 88.73% <0.00%> (-4.23%) ⬇️
devito/symbolics/queries.py 61.29% <ø> (-16.61%) ⬇️
devito/symbolics/search.py 97.50% <ø> (-0.26%) ⬇️
tests/test_mpi.py 99.05% <ø> (ø)
devito/symbolics/printer.py 73.49% <77.77%> (+0.52%) ⬆️
devito/passes/clusters/aliases.py 97.06% <97.39%> (+0.46%) ⬆️
devito/core/cpu.py 100.00% <100.00%> (ø)
devito/finite_differences/coefficients.py 93.05% <100.00%> (+1.18%) ⬆️
devito/finite_differences/finite_difference.py 96.07% <100.00%> (+0.07%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4471237...d295607. Read the comment docs.

@EdCaunt EdCaunt force-pushed the small_custom_coefficients_fix branch from 89d28b6 to ef19c4a Compare March 23, 2021 13:18
@EdCaunt EdCaunt requested review from rhodrin, FabioLuporini and mloubout and removed request for rhodrin March 24, 2021 12:22
@mloubout mloubout added API api (symbolics, types, ...) bug-py labels Mar 24, 2021
@EdCaunt EdCaunt self-assigned this Mar 24, 2021
@FabioLuporini
Copy link
Contributor

closing, as superseded by #1644

@EdCaunt EdCaunt deleted the small_custom_coefficients_fix branch July 9, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API api (symbolics, types, ...) bug-py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants