Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Remove increments from SubDimension names #2257

Closed
wants to merge 27 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
9dc4682
WIP
FabioLuporini Oct 18, 2023
da6975b
types: Started work on functionality to resolve clashing dimension na…
EdCaunt Nov 1, 2023
d1a73d7
types: Tidy up and investigation into failures
EdCaunt Nov 1, 2023
0426692
types: Unclashing now works, but is too eager
EdCaunt Nov 2, 2023
f2322c5
types: Consistent failure pattern now
EdCaunt Nov 2, 2023
15cb6a9
tests: Tightened relational_classes test
EdCaunt Nov 2, 2023
bec6aa7
misc: tidy up
EdCaunt Nov 2, 2023
52a9a6e
compiler: Widened dimension search to include ConditionalDimension co…
EdCaunt Nov 2, 2023
99c4d49
compiler: Limited dimension extraction to indices and included Condit…
EdCaunt Nov 3, 2023
39aa594
dsl: Modifications to uxreplace
EdCaunt Nov 3, 2023
0442dc2
dsl: uxreplace now applies to ConditionalDimension conditions
EdCaunt Nov 3, 2023
3b2a7d9
misc: Tidy up
EdCaunt Nov 3, 2023
b0308a1
tests: Added test for new uxreplace functionality
EdCaunt Nov 3, 2023
f86178b
misc: Tidy up
EdCaunt Nov 3, 2023
e95a51b
dsl: Tweaked uxreplace
EdCaunt Nov 3, 2023
59dd3ae
dsl: Added deep mode to uxreplace
EdCaunt Nov 6, 2023
b946c7c
dsl: uxreplace now uses underlying attributes rather than properties …
EdCaunt Nov 6, 2023
0418235
mpi: Extended uxreplace deep option to halotouch
EdCaunt Nov 6, 2023
2f64dfc
dsl: added dxreplace for uxreplace + dimension substitution
EdCaunt Nov 7, 2023
6477cd8
compiler: Moved dimension unclashing after creation of LoweredEq
EdCaunt Nov 8, 2023
907d1d4
dsl: dxreplace now replaces dimensions inside ConditionalDimension fa…
EdCaunt Nov 8, 2023
b29d087
misc: flake8
EdCaunt Nov 9, 2023
6e3f274
types: Restored increments on SubDimension bounds
EdCaunt Nov 10, 2023
66abbc5
types: Updated dimension tagging for SubDomainSet
EdCaunt Nov 10, 2023
60a5d0d
tests: Updated tree structures to match new dimension names
EdCaunt Nov 14, 2023
fc322c1
examples: Updated the generated code printed in the convection example
EdCaunt Nov 14, 2023
6eeb17b
examples: Updated the SubDomains notebook
EdCaunt Nov 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: Updated tree structures to match new dimension names
  • Loading branch information
EdCaunt committed Nov 14, 2023
commit 60a5d0de5603ea463de1d29d3b4dc695efb0ab3a
2 changes: 1 addition & 1 deletion tests/test_fission.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def define(self, dimensions):

# Note the `x` loop is fissioned, so now both loop nests can be collapsed
# for maximum parallelism
assert_structure(op, ['t,x,i1y', 't,x,i2y'], 't,x,i1y,x,i2y')
assert_structure(op, ['t,x,y', 't,x,y'], 't,x,y,x,y')


def test_nofission_as_unprofitable():
Expand Down
24 changes: 12 additions & 12 deletions tests/test_subdomains.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ class DummySubdomains(SubDomainSet):
# Make sure it jit-compiles
op.cfunction

assert_structure(op, ['x,y', 't,n0', 't,n0,xi2,yi2'], 'x,y,t,n0,xi2,yi2')
assert_structure(op, ['x,y', 't,n1', 't,n1,x,y'], 'x,y,t,n1,x,y')

def test_issue_1761_b(self):
"""
Expand Down Expand Up @@ -486,8 +486,8 @@ class DummySubdomains2(SubDomainSet):
op.cfunction

assert_structure(op,
['x,y', 't,n0', 't,n0,xi2,yi2', 't,n1', 't,n1,xi3,yi3'],
'x,y,t,n0,xi2,yi2,n1,xi3,yi3')
['x,y', 't,n1', 't,n1,x,y', 't,n2', 't,n2,x,y'],
'x,y,t,n1,x,y,n2,x,y')

def test_issue_1761_c(self):
"""
Expand Down Expand Up @@ -522,9 +522,9 @@ class DummySubdomains2(SubDomainSet):
# Make sure it jit-compiles
op.cfunction

assert_structure(op, ['x,y', 't,n0', 't,n0,xi2,yi2',
't,n1', 't,n1,xi3,yi3', 't,n0', 't,n0,xi2,yi2'],
'x,y,t,n0,xi2,yi2,n1,xi3,yi3,n0,xi2,yi2')
assert_structure(op, ['x,y', 't,n1', 't,n1,x,y',
't,n2', 't,n2,x,y', 't,n1', 't,n1,x,y'],
'x,y,t,n1,x,y,n2,x,y,n1,x,y')

def test_issue_1761_d(self):
"""
Expand All @@ -549,8 +549,8 @@ class Dummy(SubDomainSet):
# Make sure it jit-compiles
op.cfunction

assert_structure(op, ['t,n0', 't,n0,xi2,yi2', 't,n0,xi2,yi2'],
't,n0,xi2,yi2,xi2,yi2')
assert_structure(op, ['t,n1', 't,n1,x,y', 't,n1,x,y'],
't,n1,x,y,x,y')

def test_guarding(self):

Expand All @@ -577,8 +577,8 @@ class Dummy(SubDomainSet):
# Make sure it jit-compiles
op.cfunction

assert_structure(op, ['t', 't,n0', 't,n0,xi2,yi2', 't,n0', 't,n0,xi2,yi2'],
't,n0,xi2,yi2,n0,xi2,yi2')
assert_structure(op, ['t', 't,n1', 't,n1,x,y', 't,n1', 't,n1,x,y'],
't,n1,x,y,n1,x,y')

def test_3D(self):

Expand All @@ -598,8 +598,8 @@ class Dummy(SubDomainSet):
# Make sure it jit-compiles
op.cfunction

assert_structure(op, ['t,n0', 't,n0,xi20_blk0,yi20_blk0,xi2,yi2,zi2'],
't,n0,xi20_blk0,yi20_blk0,xi2,yi2,zi2')
assert_structure(op, ['t,n1', 't,n1,x0_blk0,y0_blk0,x,y,z'],
't,n1,x0_blk0,y0_blk0,x,y,z')

def test_sequential_implicit(self):
"""
Expand Down