api: Make Derivative Reconstructable #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2429 +/- ##
=======================================
Coverage 86.98% 86.99%
=======================================
Files 236 236
Lines 44811 44821 +10
Branches 8359 8360 +1
=======================================
+ Hits 38981 38991 +10
Misses 5101 5101
Partials 729 729 ☔ View full report in Codecov by Sentry. |
EdCaunt
reviewed
Jul 25, 2024
| @@ -713,6 +713,16 @@ def test_deriv_spec(self): | |||
| assert dxy0.x0 == {y: y+y.spacing/2} | |||
| assert dxy02.x0 == {x: x+x.spacing/2} | |||
|
|
|||
| def test_deriv_stagg_plain(self): | |||
There was a problem hiding this comment.
Would it be worth also testing evaluating staggered=None onto staggered=x? Also potentially mixing staggered=None and staggered=NODE
There was a problem hiding this comment.
That would not be the point of this test which is to evaluate at the same point for different function, evaluation for proper staggering is already tested in multiple places
mloubout
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://devitocodes.slack.com/archives/C1HSXP6KB/p1721850267638059