compiler: Remove counters from subdomains and automatically generate unique names #2431

EdCaunt · 2024-07-30T12:17:24Z

Rather than using counters to ensure subdimensions etc are unique, they should be dynamically renamed during compilation.

Supersedes #2405 .

codecov · 2024-07-30T12:51:12Z

Codecov Report

Attention: Patch coverage is 98.18182% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.07%. Comparing base (28e5ef2) to head (6ed3979).
Report is 18 commits behind head on master.

Files with missing lines	Patch %	Lines
devito/ir/equations/algorithms.py	95.52%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
+ Coverage   87.00%   87.07%   +0.06%     
==========================================
  Files         239      239              
  Lines       45028    45117      +89     
  Branches     8406     8427      +21     
==========================================
+ Hits        39177    39285     +108     
+ Misses       5116     5100      -16     
+ Partials      735      732       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devito/ir/equations/algorithms.py

devito/types/grid.py

review-notebook-app · 2024-07-30T16:01:12Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

FabioLuporini

This is looking so good

devito/ir/equations/algorithms.py

devito/ir/iet/utils.py

devito/passes/iet/definitions.py

devito/types/basic.py

devito/ir/equations/algorithms.py

tests/test_dimension.py

tests/test_subdomains.py

devito/ir/equations/algorithms.py

devito/types/basic.py

devito/ir/equations/algorithms.py

devito/types/dimension.py

devito/types/basic.py

devito/ir/equations/algorithms.py

devito/ir/support/symregistry.py

devito/ir/equations/algorithms.py

devito/ir/support/symregistry.py

devito/ir/equations/algorithms.py

FabioLuporini · 2024-09-26T14:45:30Z

GTG!

…ilding

…user

EdCaunt requested review from FabioLuporini and mloubout July 30, 2024 12:22

EdCaunt force-pushed the counters_redux branch from db231d0 to 7db7246 Compare July 30, 2024 12:31

georgebisbas reviewed Jul 30, 2024

View reviewed changes

devito/ir/equations/algorithms.py Show resolved Hide resolved

devito/ir/equations/algorithms.py Show resolved Hide resolved

devito/types/grid.py Show resolved Hide resolved

FabioLuporini reviewed Jul 31, 2024

View reviewed changes

georgebisbas added the compiler label Jul 31, 2024

ZoeLeibowitz reviewed Jul 31, 2024

View reviewed changes

devito/ir/equations/algorithms.py Outdated Show resolved Hide resolved

devito/ir/equations/algorithms.py Outdated Show resolved Hide resolved

tests/test_dimension.py Outdated Show resolved Hide resolved

tests/test_subdomains.py Outdated Show resolved Hide resolved

mloubout reviewed Jul 31, 2024

View reviewed changes

devito/ir/equations/algorithms.py Outdated Show resolved Hide resolved

mloubout reviewed Jul 31, 2024

View reviewed changes

devito/ir/equations/algorithms.py Outdated Show resolved Hide resolved

devito/types/basic.py Outdated Show resolved Hide resolved

EdCaunt requested review from FabioLuporini and georgebisbas July 31, 2024 16:26

mloubout reviewed Jul 31, 2024

View reviewed changes

devito/types/basic.py Outdated Show resolved Hide resolved

This was referenced Aug 1, 2024

dsl: Fix missing sympy assumptions during rebuilding #2436

Merged

dsl: Remove counters for SubDomains and MultiSubDomains #2405

Closed

EdCaunt force-pushed the counters_redux branch from a98d91f to 09a44e0 Compare August 2, 2024 12:09

FabioLuporini reviewed Aug 6, 2024

View reviewed changes

devito/ir/equations/algorithms.py Outdated Show resolved Hide resolved

FabioLuporini reviewed Aug 6, 2024

View reviewed changes

devito/ir/equations/algorithms.py Outdated Show resolved Hide resolved

FabioLuporini reviewed Aug 6, 2024

View reviewed changes

devito/types/dimension.py Outdated Show resolved Hide resolved

mloubout reviewed Aug 6, 2024

View reviewed changes

devito/types/basic.py Outdated Show resolved Hide resolved

EdCaunt force-pushed the counters_redux branch from 09a44e0 to 4f6d84b Compare September 4, 2024 13:51

EdCaunt requested review from FabioLuporini and mloubout September 4, 2024 16:42

mloubout reviewed Sep 13, 2024

View reviewed changes

devito/ir/equations/algorithms.py Outdated Show resolved Hide resolved

mloubout approved these changes Sep 13, 2024

View reviewed changes

EdCaunt force-pushed the counters_redux branch 2 times, most recently from 4f18c77 to de56705 Compare September 16, 2024 10:53

EdCaunt force-pushed the counters_redux branch from de56705 to 1297db1 Compare September 24, 2024 15:48

mloubout reviewed Sep 25, 2024

View reviewed changes

devito/ir/support/symregistry.py Show resolved Hide resolved

FabioLuporini reviewed Sep 26, 2024

View reviewed changes

FabioLuporini approved these changes Sep 26, 2024

View reviewed changes

EdCaunt force-pushed the counters_redux branch from c989bc0 to 2417758 Compare September 27, 2024 13:43

EdCaunt added 17 commits October 3, 2024 16:44

compiler: Generate subdimension ids during compilation

e22260f

compiler: Rework concretize_subdomains

4c124e1

dsl: Rebuild SubDomainSet functions

14fbd23

compiler: Add handling for ConditionalDimension

ef0e32c

compiler: Simplify concretize_subdims

e59bcc5

compiler: Tweak subdim concretisation

a704295

compiler: Remove unneeded machinery from concretize_subdims

cb9fbd8

compiler: Introduced additional mappings for indexed Arrays

54d07b2

tests: Add tests for subdimension renaming

e8c281e

examples: Update subdomain notebook

053c70e

compiler: Avoid reassigning data during MultiSubDimension rebuilding

8b1950b

compiler: Ensure MultiSubDimension functions have unique names

8026a03

compiler: Refactor MultiSubDimension concretisation

45f87e8

compiler: Remove unnecessary multisubdimension rebuild args

4730af0

misc: Fix use of ExternalAllocator

7f43aa9

compiler: Fix issue where untouched data would be petrified upon rebu…

d7de9e0

…ilding

compiler: Tweak renaming to operate after first encountered and warn …

6ed3979

…user

EdCaunt force-pushed the counters_redux branch from 2417758 to 6ed3979 Compare October 3, 2024 15:45

mloubout merged commit db692d2 into master Oct 3, 2024
31 checks passed

mloubout deleted the counters_redux branch October 3, 2024 17:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compiler: Remove counters from subdomains and automatically generate unique names #2431

compiler: Remove counters from subdomains and automatically generate unique names #2431

EdCaunt commented Jul 30, 2024

codecov bot commented Jul 30, 2024 •

edited

Loading

review-notebook-app bot commented Jul 30, 2024

FabioLuporini left a comment

FabioLuporini commented Sep 26, 2024

compiler: Remove counters from subdomains and automatically generate unique names #2431

compiler: Remove counters from subdomains and automatically generate unique names #2431

Conversation

EdCaunt commented Jul 30, 2024

codecov bot commented Jul 30, 2024 • edited Loading

Codecov Report

review-notebook-app bot commented Jul 30, 2024

FabioLuporini left a comment

Choose a reason for hiding this comment

FabioLuporini commented Sep 26, 2024

codecov bot commented Jul 30, 2024 •

edited

Loading