Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add a test-only init for issue 2448 #2465

Closed
wants to merge 2 commits into from
Closed

tests: Add a test-only init for issue 2448 #2465

wants to merge 2 commits into from

Conversation

georgebisbas
Copy link
Contributor

As discussed in the weekly meeting 24th of Sept.

#2448

@georgebisbas georgebisbas added the bug-C-minor bug in the generated code not affecting correctness label Oct 8, 2024
@georgebisbas georgebisbas self-assigned this Oct 8, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.28571% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (74f3496) to head (a09dfc4).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_mpi.py 14.28% 24 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (74f3496) and HEAD (a09dfc4). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (74f3496) HEAD (a09dfc4)
16 14
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2465      +/-   ##
==========================================
- Coverage   87.06%   78.70%   -8.37%     
==========================================
  Files         239      239              
  Lines       45123    45151      +28     
  Branches     8428     8430       +2     
==========================================
- Hits        39286    35535    -3751     
- Misses       5102     8825    +3723     
- Partials      735      791      +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabioLuporini FabioLuporini added bug-performance-C and removed bug-C-minor bug in the generated code not affecting correctness labels Oct 11, 2024
EdCaunt
EdCaunt reviewed Oct 11, 2024
View reviewed changes
tests/test_mpi.py

# First order elastic-like dependencies equations
pde_v = v.dt - (tau.dx)
pde_tau = (tau.dt - ((v.forward).dx))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: You don't need all these brackets right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorporated in #2477

tests/test_mpi.py
pde_v = v.dt - (tau.dx)
pde_tau = (tau.dt - ((v.forward).dx))

u_v = Eq(v.forward, solve(pde_v, v.forward))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work with just Eq(v.forward, tau.dx) and Eq(tau.forward, v.forward.dx)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aa I will have to try

@georgebisbas
Copy link
Contributor Author

Closing in favor of #2477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdCaunt EdCaunt EdCaunt left review comments

Assignees

@georgebisbas georgebisbas

Labels
bug-performance-C
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgebisbas @EdCaunt @FabioLuporini