Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix derivative kwargs at call #2469

Merged
merged 1 commit into from
Oct 15, 2024
Merged

api: fix derivative kwargs at call #2469

merged 1 commit into from
Oct 15, 2024

Conversation

mloubout
Copy link
Contributor

Prevent call_ to add wrong input at rebuild by only processing actual inputs

@mloubout mloubout force-pushed the fd-call branch 3 times, most recently from 1e55258 to 2a85ad5 Compare October 15, 2024 16:20
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.17%. Comparing base (fe071da) to head (8a845e3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
devito/finite_differences/derivative.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2469   +/-   ##
=======================================
  Coverage   87.16%   87.17%           
=======================================
  Files         239      239           
  Lines       45138    45160   +22     
  Branches     3998     4007    +9     
=======================================
+ Hits        39345    39367   +22     
  Misses       5112     5112           
  Partials      681      681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloubout mloubout merged commit 7795225 into master Oct 15, 2024
31 checks passed
@mloubout mloubout deleted the fd-call branch October 15, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant