Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Flake8 linting to notebooks #2484

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ci: Add Flake8 linting to notebooks #2484

wants to merge 5 commits into from

Conversation

EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Nov 13, 2024

@ggorman pointed out that you can now Flake8 lint Jupyter Notebooks. We should probably do this.

@mloubout
Copy link
Contributor

I personally wouldn't. Flake8 is really not adapted to notebooks, where readable and potentially longer lines are preferred.

@EdCaunt
Copy link
Contributor Author

EdCaunt commented Nov 13, 2024

We could always set a custom rule to ignore "line too long"

@EdCaunt
Copy link
Contributor Author

EdCaunt commented Nov 13, 2024

Looking at it, there are only about 5 "Line too long" warnings in the whole output, and most are only 5 or so characters over.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (2f18ab8) to head (be6715a).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2484      +/-   ##
==========================================
- Coverage   87.26%   87.26%   -0.01%     
==========================================
  Files         238      238              
  Lines       45278    45271       -7     
  Branches     4022     4022              
==========================================
- Hits        39512    39505       -7     
  Misses       5085     5085              
  Partials      681      681              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloubout mloubout added the CI continuous integration label Nov 13, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is way too big for just a few line change. Also those depa should be in requirements-testing.txt not hardcoded in the yaml

@EdCaunt
Copy link
Contributor Author

EdCaunt commented Nov 18, 2024

This diff is way too big for just a few line change.

Yeah, I messed up adding the changes in one of the notebooks somehow. Will fix in due course

@EdCaunt
Copy link
Contributor Author

EdCaunt commented Nov 18, 2024

Also those depa should be in requirements-testing.txt not hardcoded in the yaml

I was just going off how the Flake8 workflow already works, can change this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants