misc: Prevent builtins on transient functions #2506
+42
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabioLuporini
added
the
bug-C-minor
mloubout
reviewed
Dec 20, 2024
| @wraps(func) | ||
| def wrapper(*args, **kwargs): | ||
| for i in args: | ||
| try: |
There was a problem hiding this comment.
Should only be an issue on Device platform, CPU transient do hold the data
| @@ -131,3 +132,23 @@ def wrapper(*args, **kwargs): | |||
| return func(*processed, argmap=argmap, **kwargs) | |||
|
|
|||
| return wrapper | |||
|
|
|||
|
|
|||
| def check_args(func): | |||
| @@ -518,3 +518,11 @@ def test_issue_1863(self): | |||
| assert type(v1) is np.int32 | |||
| assert type(v2) is np.float32 | |||
| assert type(v3) is np.float64 | |||
|
|
|||
| def test_is_transient(self): | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2506 +/- ##
==========================================
- Coverage 87.29% 87.11% -0.18%
==========================================
Files 238 238
Lines 45609 45634 +25
Branches 4042 4043 +1
==========================================
- Hits 39814 39756 -58
- Misses 5112 5201 +89
+ Partials 683 677 -6 ☔ View full report in Codecov by Sentry. |
georgebisbas
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.