Specular lights #15
Merged
Specular lights #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to optimize the usage of GX lights, since we don't need to always reserve a pair of lights for the ambient and diffuse components, if only one of them is used.
We add the specular lights to the first channel, along with ambient lights: ambient lights are not directional (they only depend on the distance), so we can switch the angular attenuation function to GX_AF_SPEC without affecting them. Note that there's a difference between how GX and OpenGL compute specular lights: in OpenGL, it is a combination that depends solely on the GL_SPECULAR values set on the light and on the material; but in GX, due to the fact that we have only two channels for mixing lights, we pre-multiply the two GL_SPECULAR values of the light and of the material, and then we have an additional factor which is the material ambient color and which we cannot avoid. The reason is that GX computes the resulting color of the specular light by mixing the color set on the light with the object's material.
All these multiplications are already done by the TEV in setup_render_scene(). The only exception to this is specular color, but multiplying it with the light color is wrong anyway (we produce a weaker light) and, most importantly, this light is already combined with the material's ambient color by GX (see the previous commit's explanation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, better review commit by commit.