Exposed symbols cleanup #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exporing symbols with the _ogx_ prefix greatly reduces the risk of naming collisions with the application's code. Besides the renaming, move the texture_list variable as a member of the main structure, to remove one exported symbols. Use a macro to avoid renaming all occurrences (though at some point we might want to do that).
Completely remove the DirectDrawSurface export methods, opengx is not an imaging library and does not need these methods itself. Mark a bunch of internally used functions as static. Rename the only needed external function to have the `_ogx_` prefix, in order to avoid collisions with the application's code. Afther these changes, the symbols exported by libopengx.a (except all those starting with `gl*`) are the following: - ogx_initialize (which is meant to be public) - _ogx_log_level (internal variable) - _ogx_state (internal variable) - _ogx_convert_rgb_image_to_DXT1 (internal function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is huge again due to running clang-format on image_DXT, which I previously missed. But if reviewed commit-by-commit it should not take a lot of time.