Eliminate global state, reducing technical debt #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 7, 2018 17:45
This reverts commit f4dea0b.
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
- Coverage 92.67% 0% -92.68%
=========================================
Files 28 28
Lines 846 815 -31
=========================================
- Hits 784 0 -784
- Misses 62 815 +753
Continue to review full report at Codecov.
|
vergeev
changed the title
added 12 commits
April 9, 2018 13:08
This was a premature optimization
The name config implies that this is something supposed to be changed by the client. The idea of the defaults is that they can be substituted by user-supplied values. This allows the users to store multiple versions of the config and utilize them as they wish.
This was referenced Apr 10, 2018
vergeev
changed the title
added 21 commits
April 13, 2018 16:46
… get_ast_trees
Previously it ignored the files with names starting with '.'
This will be needed for some of the validators in the general group
We avoid redundant test runs with the "session" scope and remove the .git folder so it doesn't grow infinitely large.
Some of the validators, like has_no_bom, will try to analyze the contents of the .git folder, which shouldn't happen. This is a quick fix. The more long term solution would be to rewrite the validators to use ProjectFolder methods that ignore the files of inappropriate extensions.
The error occurred if some of the tests failed and the .git/index.lock file was not deleted.
|
This is probably due to the failing build in the master branch (https://docs.codecov.io/docs/error-reference#section-missing-base-commit):
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR eliminates global state, making every parameterization possible by passing arguments to
validate.Once merged, the will close #7, #9, #39, #40, #95, #99 and #102. It will also allow to work on #45, which was blocked by #9.
Changelog:
ParsedPyFileclass was introduced, combining all the info about file location as well as the parsedastof the file.get_ast_treeswas removed and the method was was substituted with a simplerget_parsed_py_files.get_parsed_py_filesLocalRepositoryInfowas split into two classes:ProjectFolderandLocalRepository. This allows for validation of simple project folders without git repository in them.validate_repofunction is now simplyvalidate.CodeValidatoris eliminated.config.pyis renamed todefaults.pyand is used as such: not a modifiable config, but immutable defaults that are used in case nothing is specified.directories_to_skipparameter.has_no_directories_from_blacklistnow only inspects tracked directories, as it was intended.