Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues #110 #111 #116

Merged
merged 3 commits into from
Jun 29, 2018
Merged

Issues #110 #111 #116

merged 3 commits into from
Jun 29, 2018

Conversation

Ranc58
Copy link
Contributor

@Ranc58 Ranc58 commented Apr 26, 2018

issue #111) Replace has_no_long_files validator from validators to pre_validation_checks
issue #110) Create module utils
Fix test test_are_tabs_used_for_indentation for expected result js_with_tabs.js

@Ranc58
Copy link
Contributor Author

Ranc58 commented Apr 26, 2018

Hmm..Is there some troubles with Travis or is it my fault?

vergeev
vergeev approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@vergeev vergeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The PR will be merged in several days, sorry you have to wait.

The travis thing is fixed in one of the PRs, you don't need to worry about it.

@Ranc58
Copy link
Contributor Author

Ranc58 commented Apr 28, 2018

Ok! It's fine

@vergeev vergeev mentioned this pull request May 3, 2018
Merged
@Melevir Melevir merged commit a1bb76f into devmanorg:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergeev vergeev vergeev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ranc58 @vergeev @Melevir