Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation error for django files #51

Merged
merged 4 commits into from
Feb 9, 2018
Merged

Fix indentation error for django files #51

merged 4 commits into from
Feb 9, 2018

Conversation

vergeev
Copy link
Contributor

@vergeev vergeev commented Feb 9, 2018

No description provided.

@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #51 into master will increase coverage by 2.35%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   57.73%   60.09%   +2.35%     
==========================================
  Files          25       26       +1     
  Lines         814      827      +13     
==========================================
+ Hits          470      497      +27     
+ Misses        344      330      -14
Impacted Files Coverage Δ
fiasko_bro/code_validator.py 34.61% <ø> (ø) ⬆️
...est_general_validators/test_is_nesting_too_deep.py 100% <100%> (ø)
...ts/test_general_validators/test_pep8_violations.py 100% <100%> (ø) ⬆️
fiasko_bro/validators.py 41.61% <80%> (+3.6%) ⬆️
fiasko_bro/repository_info.py 86.15% <0%> (+1.53%) ⬆️
fiasko_bro/code_helpers.py 90% <0%> (+5%) ⬆️
fiasko_bro/url_helpers.py 30% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d2ffc...c1ed620. Read the comment docs.

Copy link
Contributor

@Melevir Melevir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like codecov wants tests. Add one to make him green, please.

for file_path, file_content, _ in solution_repo.get_ast_trees(with_filenames=True, with_file_content=True):
for directory in whitelist:
if directory in file_path:
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, this patterns repeats in multiple validators. Lets create issue to refactor this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is the #9 which is tied to two other issues related to technical debt.

Since fixing it means a lot of code changes, we better ensure a good test coverage first.

@vergeev
Copy link
Contributor Author

vergeev commented Feb 9, 2018

It turns out, I didn't write any tests fro is_nesting_too_deep validator. Will do in a minute.

@Melevir Melevir merged commit a8f9b43 into devmanorg:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants