-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indentation error for django files #51
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 57.73% 60.09% +2.35%
==========================================
Files 25 26 +1
Lines 814 827 +13
==========================================
+ Hits 470 497 +27
+ Misses 344 330 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like codecov wants tests. Add one to make him green, please.
for file_path, file_content, _ in solution_repo.get_ast_trees(with_filenames=True, with_file_content=True): | ||
for directory in whitelist: | ||
if directory in file_path: | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, this patterns repeats in multiple validators. Lets create issue to refactor this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is the #9 which is tied to two other issues related to technical debt.
Since fixing it means a lot of code changes, we better ensure a good test coverage first.
It turns out, I didn't write any tests fro |
No description provided.