Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#47: Support for global tools #113

Merged
merged 29 commits into from
Nov 7, 2023
Merged

#47: Support for global tools #113

merged 29 commits into from
Nov 7, 2023

Conversation

salimbouch
Copy link
Contributor

@salimbouch salimbouch commented Oct 24, 2023 •
edited
Loading

addresses #47

@salimbouch salimbouch self-assigned this Oct 24, 2023
@tobka777 tobka777 linked an issue Oct 26, 2023 that may be closed by this pull request
Support for global tools #47
Closed
@hohwille hohwille mentioned this pull request Oct 30, 2023
Open
@salimbouch salimbouch marked this pull request as ready for review October 30, 2023 19:48
@hohwille hohwille mentioned this pull request Oct 31, 2023
Merged
hohwille
hohwille approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salimbouch Thanks for your rework. Now everything is perfect. As I had quite a list of review comments and added improvements it is especially great to see that you solved it all in one shot 👍
Ready for merge.

The last comment is just for my curiosity and shall not block the merge...

cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java Show resolved Hide resolved
@hohwille hohwille added enhancement New feature or request software 3rd party software (tools) commandlet install installation process of IDE + tools and install commandlet labels Nov 7, 2023
@hohwille hohwille added this to the release:2024.01.001 milestone Nov 7, 2023
@hohwille hohwille merged commit 17f5939 into devonfw:main Nov 7, 2023
@hohwille hohwille mentioned this pull request Jan 4, 2024
Merged
@hohwille hohwille mentioned this pull request Jan 16, 2024
Merged
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@hohwille hohwille added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@salimbouch salimbouch

Labels
commandlet enhancement New feature or request install installation process of IDE + tools and install commandlet reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. software 3rd party software (tools)
Projects
None yet
Milestone
release:2024.03.001
Development

Successfully merging this pull request may close these issues.

Support for global tools
2 participants
@salimbouch @hohwille