#5: Improve access method for CommandletManager #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzLanger
added a commit
to moritzLanger/IDEasy
that referenced
this pull request
Feb 22, 2024
moritzLanger
added a commit
to moritzLanger/IDEasy
that referenced
this pull request
Mar 4, 2024
hohwille
added
story-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5
In our daily we discovered a confusion with
CommandletManagerImpl.of(null)and had a general discussion about staticofvs.getmethods:ofshall be like a "Constructor" to create a new instance of something.getshall be some kind of singleton access to get something that is already there and typically return the same instance when called multiple times.I have refactored our code and properly applied this also for
CommandletManagerImpland also improved the JavaDoc accordingly so things should be more transparent now.