Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#20: Implement ToolCommandlet for GCViewer #151

Merged
merged 17 commits into from
Jan 30, 2024
Merged

#20: Implement ToolCommandlet for GCViewer #151

merged 17 commits into from
Jan 30, 2024

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Dec 1, 2023 •
edited
Loading

This PR implements GCViewer and adds some code to handle unpacked jar files. Furthermore, it adds a workaround for sourceforge urls.

Fixes #20

@alfeilex alfeilex requested a review from aBega2000 December 6, 2023 09:39
@alfeilex alfeilex marked this pull request as ready for review December 6, 2023 09:39
@aBega2000 aBega2000 assigned alfeilex and unassigned aBega2000 Dec 7, 2023
alfeilex and others added 6 commits December 8, 2023 12:03
@coveralls
Copy link
Collaborator

coveralls commented Dec 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7709751871

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 56.184%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/util/FilenameUtil.java 1 80.65%
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java 3 87.32%
com/devonfw/tools/ide/tool/ToolCommandlet.java 21 44.88%
Totals Coverage Status
Change from base Build 7709698093: -0.08%
Covered Lines: 3645
Relevant Lines: 6238
💛 - Coveralls

hohwille
hohwille requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex Thanks for this PR. Looks good to me 👍
I left some comments for improvements, one is most probably a bug that needs to be fixed before we can merge.

cli/src/main/java/com/devonfw/tools/ide/tool/gcviewer/GcViewer.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/util/FilenameUtil.java Outdated Show resolved Hide resolved
@tobka777 tobka777 assigned hohwille and unassigned alfeilex Jan 25, 2024
hohwille
hohwille approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex Excellent! Thanks for making this perfect 👍
Ready for merge.

@hohwille hohwille added the gcviewer GUI to visualize logs of Java Garbage Collector label Jan 30, 2024
@hohwille hohwille added commandlet enhancement New feature or request labels Jan 30, 2024
@hohwille hohwille added this to the release:2024.02.001 milestone Jan 30, 2024
@hohwille hohwille merged commit 830c11f into devonfw:main Jan 30, 2024
3 checks passed
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@alfeilex alfeilex deleted the gcviewer branch August 6, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aBega2000 aBega2000 aBega2000 approved these changes

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

Labels
commandlet enhancement New feature or request gcviewer GUI to visualize logs of Java Garbage Collector story-review marks PRs that will be presented in the sprint-review
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.03.001
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for GCViewer
6 participants
@alfeilex @coveralls @hohwille @aBega2000 @diiinesh @tobka777