Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#146 Implement automated coverage tools #152

Merged

Conversation

moritzLanger
Copy link
Contributor

@moritzLanger moritzLanger commented Dec 11, 2023

closes #146 implement automated coverage tool

Jacoco has been added

Coverall has been added to the GitHub workflow, to be used in PRs
Some Steps are needed to activate Coverall:

  • 1. Sign up to Coveralls.io on their website using the Repo owner
  • 2. On the Coverall website navigate to settings and Activate "leave comments?" and set them to detailed, bevor saving the changes. (Once signed up the link to the settings will be https://coveralls.io/github/devonfw/IDEasy/settings )
  • 3. The coverall bot needs to be added to the repo, with write permissions (https://github.com/coveralls)

(Documentation can also be found on the Coveralls docu page )

@moritzLanger
Copy link
Contributor Author

I was able to skip step 1. and complete step 2. (as I was allowed to change settings in coverall for defonfw/ideasy)

@tobka777 tobka777 requested a review from MattesMrzik December 11, 2023 09:36
@moritzLanger moritzLanger marked this pull request as ready for review December 11, 2023 09:36
@MattesMrzik
Copy link
Contributor

... and complete step 2. (as I was allowed to change settings in coverall for defonfw/ideasy)

I think this setting can be changed by anyone on the web. Can we restrict this?

@moritzLanger
Copy link
Contributor Author

... and complete step 2. (as I was allowed to change settings in coverall for defonfw/ideasy)

I think this setting can be changed by anyone on the web. Can we restrict this?

The settings can be changed by anyone within the Devonfw Github Group, but i can look into restricting it further

Copy link
Contributor

@MattesMrzik MattesMrzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MattesMrzik MattesMrzik removed their assignment Dec 14, 2023
@MattesMrzik MattesMrzik requested a review from hohwille December 14, 2023 10:26
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moritzLanger Thanks for creating the PR. Looks all great. 👍
Also you used the latest version of the plugin what is always a best-practice
https://repo1.maven.org/maven2/org/jacoco/jacoco-maven-plugin/

@hohwille
Copy link
Member

For the record: I did not grant "Write permissions" to coveralls as reading the documentation I found out that read access is sufficient. We will see if all works out or not.

@hohwille
Copy link
Member

one last thing @moritzLanger
IMHO you forgot to add the badge for coveralls to our README in this PR.
Can you afterwards create a new PR for that.

@hohwille hohwille added this to the release:2024.01.001 milestone Dec 15, 2023
@hohwille hohwille merged commit 4c46eb6 into devonfw:main Dec 15, 2023
2 checks passed
hohwille added a commit that referenced this pull request Dec 15, 2023
@hohwille
Copy link
Member

one last thing @moritzLanger IMHO you forgot to add the badge for coveralls to our README in this PR. Can you afterwards create a new PR for that.

I just did it myself. Done.

@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story-review marks PRs that will be presented in the sprint-review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Implement automated coverage tools
3 participants