-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#146 Implement automated coverage tools #152
#146 Implement automated coverage tools #152
Conversation
I was able to skip step 1. and complete step 2. (as I was allowed to change settings in coverall for defonfw/ideasy) |
I think this setting can be changed by anyone on the web. Can we restrict this? |
The settings can be changed by anyone within the Devonfw Github Group, but i can look into restricting it further |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moritzLanger Thanks for creating the PR. Looks all great. 👍
Also you used the latest version of the plugin what is always a best-practice
https://repo1.maven.org/maven2/org/jacoco/jacoco-maven-plugin/
For the record: I did not grant "Write permissions" to |
one last thing @moritzLanger |
I just did it myself. Done. |
closes #146 implement automated coverage tool
Jacoco has been added
Coverall has been added to the GitHub workflow, to be used in PRs
Some Steps are needed to activate Coverall:
(Documentation can also be found on the Coveralls docu page )