#158: VersionRange with open boundaries #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the VersionRange to also model open boundaries that do not include the specified value. Also wrote tests for this class.
Pull Request Test Coverage Report for Build 7449724212
💛 - Coveralls |
aBega2000
reviewed
Dec 19, 2023
cli/src/main/java/com/devonfw/tools/ide/version/VersionRange.java
Outdated
Show resolved
Hide resolved
aBega2000
approved these changes
Jan 8, 2024
hohwille
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
@MattesMrzik thanks for this PR and rework. 👍
I added 2 suggestions. If you can agree and accept, we can merge this immediately.
cli/src/main/java/com/devonfw/tools/ide/version/VersionRange.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/version/VersionRange.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jörg Hohwiller <[email protected]>
Co-authored-by: Jörg Hohwiller <[email protected]>
hohwille
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
@MattesMrzik thanks for the fast rework and fixing the bug in my suggested code 👍
Ready for merge now.
hohwille
added
the
story-review
hohwille
added
the
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the VersionRange to also model open boundaries that do not include the specified value. Also wrote tests for this class.
Closes #158.