Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7: add Tag class with predefined tags #166

Merged
merged 6 commits into from
Jan 16, 2024
Merged

#7: add Tag class with predefined tags #166

merged 6 commits into from
Jan 16, 2024

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Jan 5, 2024

#7: add Tag class with predefined tags including taxonomy/hierarchy add synonyms

@hohwille hohwille added this to the release:2024.01.001 milestone Jan 5, 2024
@hohwille hohwille linked an issue Jan 5, 2024 that may be closed by this pull request
Ability to tag plugins and tools #7
Closed
3 tasks
@hohwille hohwille added the enhancement New feature or request label Jan 5, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7541338767

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 54.968%
Totals Coverage Status
Change from base Build 7541085130: 1.1%
Covered Lines: 3296
Relevant Lines: 5771
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new tags are really nice.
I've fixed some typos and added one question. Looks good to me.

cli/src/main/java/com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java Show resolved Hide resolved
aBega2000
aBega2000 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@aBega2000 aBega2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation of Tags looks really nice. Jan already fixed some small typos, and from my side everything else looks correct.

@tobka777 tobka777 assigned hohwille and unassigned jan-vcapgemini and aBega2000 Jan 11, 2024
@hohwille hohwille merged commit f75bfa6 into devonfw:main Jan 16, 2024
4 checks passed
jan-vcapgemini
jan-vcapgemini reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@hohwille hohwille mentioned this pull request Jan 23, 2024
Merged
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini left review comments

@aBega2000 aBega2000 aBega2000 approved these changes

Assignees

@hohwille hohwille

Labels
enhancement New feature or request story-review marks PRs that will be presented in the sprint-review
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.03.001
Development

Successfully merging this pull request may close these issues.

Ability to tag plugins and tools
4 participants
@hohwille @coveralls @jan-vcapgemini @aBega2000