#180 commandlet to set edition #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t' of https://github.com/MattesMrzik/IDEasy into feature/#180-feature-to-set-tool-edition-with-commandlet
…ture/#180-feature-to-set-tool-edition-with-commandlet # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java # cli/src/main/java/com/devonfw/tools/ide/process/ProcessResult.java # cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java # cli/src/main/resources/nls/Ide.properties # cli/src/main/resources/nls/Ide_de.properties
…mmandlet-to-set-tool-edition
Pull Request Test Coverage Report for Build 7873667859Details
💛 - Coveralls |
hohwille
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
@salimbouch thanks for your PR. Looking very good to me - great work 👍
Also thanks for fixing typos and wrong (C&P) JavaDoc from others.
I left some last remarks to improve.
Also instead of adding .gitkeep to _ide/urls/mvn/secondMvnEdition/ it may make more sense to add urls file here (more consistent structure).
cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/UrlMetadata.java
Outdated
Show resolved
Hide resolved
hohwille
added
the
story-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves reviews of #181 and adjusts unit tests, closes #180