Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#296 Replace InetAddress.isReachable with alternative #375

Merged
merged 2 commits into from
Jun 12, 2024
Merged

#296 Replace InetAddress.isReachable with alternative #375

merged 2 commits into from
Jun 12, 2024

Conversation

slskiba
Copy link
Contributor

@slskiba slskiba commented Jun 4, 2024

Fixes #296.

InetAddress.isReachable() seems to require root privileges to run properly on unix.

Solution not tested on MacOS.

@slskiba slskiba self-assigned this Jun 4, 2024
@slskiba slskiba requested a review from mvomiero June 4, 2024 07:32
@coveralls
Copy link
Collaborator

coveralls commented Jun 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9481719569

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 84 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 59.804%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/context/AbstractIdeContext.java 84 56.68%
Totals Coverage Status
Change from base Build 9481714774: -0.02%
Covered Lines: 4671
Relevant Lines: 7523
💛 - Coveralls

mvomiero
mvomiero approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@mvomiero mvomiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your implementation 🚀

Tested on mac and works properly!

@mvomiero mvomiero requested a review from hohwille June 5, 2024 10:12
hohwille
hohwille approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba Thanks for your PR. Reading the HTML seems to be little bit more of waste but thanks to @mvomiero your approach is confirmed to work so we have a good solution. 👍
Ready for merge.

@hohwille hohwille merged commit e061084 into devonfw:main Jun 12, 2024
3 checks passed
@hohwille hohwille added this to the release:2024.06.001 milestone Jun 12, 2024
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvomiero mvomiero mvomiero approved these changes

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

@slskiba slskiba

Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.06.001
Development

Successfully merging this pull request may close these issues.

inOnline() Method of AbstractIdeContext does not work properly
4 participants
@slskiba @coveralls @hohwille @mvomiero