Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#126: Add Monitoring for IDE Urls Updater #584

Merged
merged 27 commits into from
Sep 6, 2024

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Sep 4, 2024

Fixes: #126
Old PR: #160 (replaced because the old PR is outdated)

This PR add a monitoring to track successful and failed additions and verification of URL updates.

Summary:
This PR implements new report models classes for monitoring url updates

  • UrlUpdaterReport: Collect information like number of verifications that failed or succeeded
  • UrlFinalReport: Collect UrlUpdaterReport instances and return the output in format
    «tool»/«edition»: versions added: 5 failed, 7 succeeded, 13 total, 38,4% error - versions verified: 0 failed, 0 succeeded, 0 total, 0% error
    after the UpdateManager finished all url updates

@coveralls
Copy link
Collaborator

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10736565087

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 64 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.1%) to 65.163%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/url/updater/JsonUrlUpdater.java 5 82.14%
com/devonfw/tools/ide/url/updater/AbstractProcessorWithTimeout.java 7 60.0%
com/devonfw/tools/ide/url/UpdateInitiator.java 12 0.0%
com/devonfw/tools/ide/url/updater/UpdateManager.java 16 0.0%
com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java 24 83.01%
Totals Coverage Status
Change from base Build 10736543309: -0.1%
Covered Lines: 5844
Relevant Lines: 8651

💛 - Coveralls

@alfeilex alfeilex marked this pull request as ready for review September 4, 2024 19:19
@alfeilex alfeilex marked this pull request as draft September 5, 2024 08:13
@alfeilex alfeilex marked this pull request as ready for review September 5, 2024 10:47
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for your PR. Excellent solution now - very well done. 👍
I left a small comment that you could apply.
Then we can merge.

@hohwille hohwille added this to the release:2024.09.001 milestone Sep 6, 2024
@hohwille hohwille added urls ide-urls repo and related processes and features SCM software-configuration-management (github actions, internal processes, git or github utilization) labels Sep 6, 2024
@hohwille hohwille merged commit e68ff98 into devonfw:main Sep 6, 2024
4 checks passed
@alfeilex alfeilex deleted the error-report branch September 10, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SCM software-configuration-management (github actions, internal processes, git or github utilization) urls ide-urls repo and related processes and features
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add monitoring and check to ide-urls
3 participants