Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid duplicated initialization of IDEasy #934

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

hohwille
Copy link
Member

with #779 we have now functions getting sourced from .bashrc and that script already triggers an initialization.
As a leftover we still had the invocation of ide init in .bashrc causing a duplicate init that does not make any sense.
Also we might remove init as valid arg for ide command/function and therefore do not want to have such leftovers in .bashrc files of our users (from previous releases).
Having just a single line in .bashrc that will stay stable forever is the perfect solution.

@hohwille hohwille added enhancement New feature or request bash install installation process of IDE + tools and install commandlet labels Jan 14, 2025
@hohwille hohwille added this to the release:2025.01.001 milestone Jan 14, 2025
@hohwille hohwille self-assigned this Jan 14, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12814142867

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.83%

Totals Coverage Status
Change from base Build 12807995443: 0.0%
Covered Lines: 6969
Relevant Lines: 9905

💛 - Coveralls

@hohwille hohwille merged commit 0dc965a into devonfw:main Jan 16, 2025
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash enhancement New feature or request install installation process of IDE + tools and install commandlet reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants