Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#919: Require user to agree to license #948

Merged
merged 9 commits into from
Jan 20, 2025
Merged

#919: Require user to agree to license #948

merged 9 commits into from
Jan 20, 2025

Conversation

hohwille
Copy link
Member

fixes #919

@hohwille hohwille added enhancement New feature or request CLI IDEasy command-line-interface (parsing args, etc.) labels Jan 17, 2025
@hohwille hohwille added this to the release:2025.01.001 milestone Jan 17, 2025
@hohwille hohwille self-assigned this Jan 17, 2025
jan-vcapgemini
jan-vcapgemini reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added some CRs and questions, please resolve.

cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java Outdated Show resolved Hide resolved
cli/src/main/package/setup.bat Show resolved Hide resolved
cli/src/main/package/setup Show resolved Hide resolved
@jan-vcapgemini jan-vcapgemini self-assigned this Jan 20, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12876054103

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 162 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 68.126%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/HelpCommandlet.java 2 94.12%
com/devonfw/tools/ide/context/IdeContext.java 20 63.92%
com/devonfw/tools/ide/context/AbstractIdeContext.java 140 59.25%
Totals Coverage Status
Change from base Build 12875831187: -0.2%
Covered Lines: 7080
Relevant Lines: 10016
💛 - Coveralls

@hohwille
Copy link
Member Author

Resolved the review comments.
Additionally I also addressed the main problem/concern that the current implementation could cause the situation that the user gets totally blocked and unable to open any bash terminal any more. This is now also fixed and therefore ready for merge.

@hohwille hohwille merged commit afc09e7 into devonfw:main Jan 20, 2025
3 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini left review comments

Assignees

@hohwille hohwille

@jan-vcapgemini jan-vcapgemini

Labels
CLI IDEasy command-line-interface (parsing args, etc.) enhancement New feature or request reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.01.001
Development

Successfully merging this pull request may close these issues.

Require user to agree to license
3 participants
@hohwille @coveralls @jan-vcapgemini