Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#975: addon changes corresponding to issue 853 #977

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

yurii-yu
Copy link
Contributor

closes #975

elaborate the fix of #853

  • refine the help message to avoid confusing
  • add an unit test for ide repository ( setup is expected to appear when the auto-complete is called)

@yurii-yu yurii-yu added the enhancement New feature or request label Jan 22, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2025

Pull Request Test Coverage Report for Build 12954285144

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 68.499%

Totals Coverage Status
Change from base Build 12950192250: 0.06%
Covered Lines: 7206
Relevant Lines: 10131

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurii-yu thanks for your additions to the repository commandlet. Looks good to me, I've added only one small CR to resolve.

cli/src/main/resources/nls/Help_de.properties Outdated Show resolved Hide resolved
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ready for review now.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurii-yu thanks for this PR. You both improved the help messages to improve UX and make it easier for end-users to find how to use IDEasy and improved the tests for the new auto-completion improvement. Nice job 👍
Ready for merge.

cli/src/main/resources/nls/Help_de.properties Outdated Show resolved Hide resolved
@hohwille hohwille added this to the release:2025.01.003 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Add-on changes to Issue 853
4 participants