Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#984: windows documentation: typo's correction #986

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

zeva369
Copy link
Contributor

@zeva369 zeva369 commented Jan 24, 2025

The most obvious errors have been fixed.
Hope it helps.

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025

CLA assistant check
All committers have signed the CLA.

@hohwille
Copy link
Member

@zeva369 thank you very much for fixing our typos.
Great that you provide everything as PR and also signed the CLA so we can just merge. 👍

@zeva369
Copy link
Contributor Author

zeva369 commented Jan 24, 2025

Thanks to you, I'm new to this and I'm glad to help. 👍

@hohwille hohwille linked an issue Jan 24, 2025 that may be closed by this pull request
@hohwille hohwille added this to the release:2025.01.002 milestone Jan 24, 2025
@hohwille hohwille added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 24, 2025
@hohwille hohwille changed the title windows documentation: typo's correction #984: windows documentation: typo's correction Jan 24, 2025
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one very little change that was not fixing a typo even though it looked like one.
Once resolved, ready for merge.

documentation/advanced-tooling-windows.adoc Outdated Show resolved Hide resolved
@hohwille hohwille self-assigned this Jan 24, 2025
@jan-vcapgemini
Copy link
Contributor

jan-vcapgemini commented Jan 24, 2025

@zeva369, also thanks for your corrections. If you want to provide further assistance, it would be nice if you could attach your commits to the respective issues too. This will help us a lot in managing the tasks. See: https://github.com/devonfw/IDEasy/blob/main/documentation/IDEasy-contribution-rules-and-guidelines.adoc#commit
This issue: #984 was actually intended as a beginner task for one of our devs to get used to our workflow. You've taken it over way faster than we've imagined ^^
#985 will try to correct other issues, if any are left.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12949819777

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.444%

Totals Coverage Status
Change from base Build 12927675457: 0.0%
Covered Lines: 7201
Relevant Lines: 10131

💛 - Coveralls

@hohwille hohwille merged commit 004264f into devonfw:main Jan 24, 2025
4 checks passed
@zeva369
Copy link
Contributor Author

zeva369 commented Jan 24, 2025

I found one very little change that was not fixing a typo even though it looked like one. Once resolved, ready for merge.

I'm sorry, i was not sure about that one,
i've tried to test the link in order to check if it worked but got 'not found' so i thought it was a typo.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Fix typos and links in advanced-tooling-windows
5 participants