#1509 Adapt template sets in Eclipse #1631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cedric Betom seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 2 commits
January 18, 2023 16:04
enableCrossOsArchive in restore p2 cache
jan-vcapgemini
approved these changes
Jan 24, 2023
Comment on lines
34
to
43
| /** Temporary files rule to create temporary folders or files */ | ||
| @Rule | ||
| public TemporaryFolder tempFolder = new TemporaryFolder(); | ||
|
|
||
| /** Root path of the Test Resources */ | ||
| private static final String resourcesRootPath = "src/main/resources/OpenAPITest/"; | ||
|
|
||
| /** Line separator, e.g. for windows '\r\n' */ | ||
| public static final String LINE_SEPARATOR = java.lang.System.getProperty("line.separator"); | ||
|
|
There was a problem hiding this comment.
Not so easy to follow changes, please put a reformat in a separate commit.
…efore or after the adapt command into consideration
… template-set->downloaded to adapted directory
EduardKrieger
requested review from
Ali7223,
NelsonNew,
quantumfate,
sarahffm and
ZakariaeMkassi
EduardKrieger
requested changes
Feb 7, 2023
.../cobigen-eclipse-test/src/main/java/com/devonfw/cobigen/eclipse/test/AdaptTemplatesTest.java
Show resolved
Hide resolved
KHucklenbroich
requested changes
Feb 9, 2023
| withEnvironmentVariable(ConfigurationConstants.CONFIG_ENV_HOME, tmpProject.getParentFile().getAbsolutePath()) | ||
| .execute(() -> testBasicOpenAPIGenerationWithAdaptTemplates()); | ||
| } | ||
| // EclipseCobiGenUtils.runAndCaptureUpdateTemplates(bot); |
There was a problem hiding this comment.
What is this commented out code for?
| * @throws Exception test fails | ||
| */ | ||
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
There should always be an explanation why a particular test is being ignored. It is probably because of the TODO?
…the download works
jan-vcapgemini
changed the title
…test # Conflicts: # cobigen-eclipse/cobigen-eclipse-test/src/main/java/com/devonfw/cobigen/eclipse/test/AdaptTemplatesTest.java # cobigen-eclipse/cobigen-eclipse/src/com/devonfw/cobigen/eclipse/common/tools/ResourcesPluginUtil.java # cobigen/cobigen-core-api/src/main/java/com/devonfw/cobigen/api/util/CobiGenPaths.java
…testBasicOpenAPIGenerationWithAdaptMonolithicTemplates
…testBasicOpenAPIGenerationWithAdaptMonolithicTemplates
|
Closed cause of CLA problems, the new PR #1654 will continue the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses/Fixes #1509.
#1622
Implements
@devonfw/cobigen