Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164 temporary workaround to fix maven-flatten-bug #335

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Conversation

maybeec
Copy link
Member

@maybeec maybeec commented Jan 25, 2021

temporary fix for #164 as of mojohaus/flatten-maven-plugin#70

@maybeec maybeec added the template maven-archetype to create new application. label Jan 25, 2021
@maybeec maybeec requested a review from hohwille February 3, 2021 08:56
@hohwille hohwille added this to the release:2020.12.003 milestone Feb 18, 2021
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maybeec thanks for this PR 👍
Sorry, it seems I missed out this PR for a while and just found it.
Looks like a reasonable workaround and quickfix and nice that you put the comment on top so we can later remove it when we can some day update flatten plugin.

@hohwille hohwille linked an issue Feb 18, 2021 that may be closed by this pull request
@hohwille hohwille added enhancement New feature or request SCM Software-configuration-management (maven, travis, etc.) labels Feb 18, 2021
@hohwille hohwille modified the milestones: release:2020.12.003, release:2021.04.001 Apr 8, 2021
@hohwille hohwille merged commit 2bba572 into master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SCM Software-configuration-management (maven, travis, etc.) template maven-archetype to create new application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flattened pom for core project invalid
2 participants