Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate own kafka implementation, recommend use of new spring-kafka, #470

Merged
merged 13 commits into from
Nov 2, 2021

Conversation

maihacke
Copy link
Member

@maihacke maihacke commented Oct 8, 2021

see #459

@maihacke maihacke requested a review from hohwille October 8, 2021 08:46
@maybeec
Copy link
Member

maybeec commented Nov 2, 2021

@maihacke could you please help with a short replace all on your PR? It was too much for me to do it by hand as there were too many files, which I can just edit by permissions within the github UI.
Please replace "Devon4Js Kafka module" with "devon4j-kafka" to not introduce non-proper spelling in all docs.

Btw. remains this PR to be WIP as stated in the headline?

@maihacke
Copy link
Member Author

maihacke commented Nov 2, 2021

@maihacke could you please help with a short replace all on your PR? It was too much for me to do it by hand as there were too many files, which I can just edit by permissions within the github UI. Please replace "Devon4Js Kafka module" with "devon4j-kafka" to not introduce non-proper spelling in all docs.

Btw. remains this PR to be WIP as stated in the headline?

I replaced every occurence as requested:

find . -type f -name '*.java' -exec sed -i '' 's/Devon4Js Kafka module/devon4j-kafka/g' {} +

Removed WIP. I still hoping to find the time to update the example app but that is another story.

@maihacke maihacke changed the title WIP: Deprecate own kafka implementation, recommend use of new spring-kafka, Deprecate own kafka implementation, recommend use of new spring-kafka, Nov 2, 2021
@maybeec maybeec added this to the release:2021.08.001 milestone Nov 2, 2021
@maybeec maybeec merged commit 12862e9 into devonfw:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants