Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pod and deployment annotations #33

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ialejandro
Copy link
Member

What this PR does / why we need it:

  • Fix annotations for pod and deployment

Which issue this PR fixes

Special notes for your reviewer:

N/A

Checklist

@ialejandro ialejandro mentioned this pull request Aug 26, 2024
2 tasks
@ialejandro ialejandro added the bug Something isn't working label Aug 26, 2024
@ialejandro ialejandro force-pushed the fix/annotations-pod-deployment branch from d1304ed to 0f81045 Compare August 26, 2024 17:34
@ialejandro ialejandro removed the request for review from amartingarcia August 26, 2024 17:34
@ialejandro ialejandro merged commit ab310e3 into main Aug 26, 2024
2 checks passed
@ialejandro ialejandro deleted the fix/annotations-pod-deployment branch August 26, 2024 17:35
@r4zr1
Copy link

r4zr1 commented Aug 26, 2024

I still have the error with this ver 😿, but my PR #32 has fixed it btw

my annotation:

connectors:
- name: splunk
  enabled: true
  replicas: 1
  podAnnotations:
    vault.security.banzaicloud.io/vault-addr: "https://vault.test:8200"
    vault.security.banzaicloud.io/vault-path: "kubernetes_itsec"
    vault.security.banzaicloud.io/vault-role: "opencti"
    vault.security.banzaicloud.io/vault-skip-verify: "true"
  image:
    repository: opencti/connector-splunk
    tag: "6.2.15"
    ...
 Error: Failed to render chart: exit status 1: Error: unable to build kubernetes objects from release manifest: error validating "":
 error validating data: [ValidationError(Deployment.spec.template.metadata.annotations.Capabilities): invalid type for
 io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta.annotations: got "map", expected "string", ValidationError(Deployment.spec.template.metadata.annotations.Chart): invalid type for io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta.annotations:
 got "map", expected "string", ValidationError(Deployment.spec.template.metadata.annotations.Files): invalid type for io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta.annotations: got "map", expected "string", ValidationError(
 Deployment.spec.template.metadata.annotations.Release): invalid type for io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta.annotations: got "map", expected "string", ValidationError(Deployment.spec.template.metadata.annotations.Subcharts): invalid type for 
 io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta.annotations: got "map", expected "string", ValidationError(
 Deployment.spec.template.metadata.annotations.Template): invalid type for 
 io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta.annotations: got "map", expected "string", ValidationError(
 Deployment.spec.template.metadata.annotations.Values): invalid type for io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta.annotations: 
 got "map", expected "string"]

@r4zr1
Copy link

r4zr1 commented Aug 26, 2024

btw
could u also add a service account definition to the connector deployment template?
like in the server and worker?

serviceAccountName: {{ include "opencti.serviceAccountName" $ }}

This was referenced Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants