Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector metric scraping: Add service and servicemonitor objects. Add port to connector to depl… #92

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

qoeveleie21
Copy link
Contributor

This PR is meant to address issue #85.

The PR contains a deployment for a service and a service monitor.

The intended behaviour is that if:

  • Metrics are enabled on the pod -> Service deployment is created
  • serviceMonitor is enabled -> the serviceMonitor deployment is created if metrics are also enabled in the container

Considerations:

  • The service deployment is not created if the metrics are not enabled as there are no other ports to expose, and the service deployment would be 'empty'
  • As connectors cannot be specified in the default values I have made the servicemonitor value optional with defaults within the chart.

Copy link
Member

@ialejandro ialejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update these files?

@ialejandro ialejandro merged commit 1e5d15b into devops-ia:main Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants