Code Improvements and Fixes #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; skipping xml preprocessing. FIXED . libxml2-utils Dependency
…ract/theme/icons/message-indicator-symbolic.svg: Directory nonexistent FIXED...
…ract/theme/icons/message-indicator-symbolic.svg: Directory nonexistent FIXED...
…; skipping xml preprocessing. FIXED . libxml2-utils Dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello sir, I've seen some errors on your script while running
Ubuntu 18.04.2on both extract.sh and build.sh.extract.sh :
./extract.sh: 12: ./extract.sh: cannot create ./scripts/gresource-extract/theme/icons/message-indicator-symbolic.svg: Directory nonexistentyou forgot to create a directory under theme named
iconsfor this reasonmessage-indicator-symbolic.svg: Directory nonexistentcan't create. so I added a way to fix this issue.build.sh : for previous issue, some fixes had been done for the build.sh and there was a dependency
(libxml2-utils)issue creating a warining message(XMLLINT not set and xmllint not found in path; skipping xml preprocessing.)and i was not aware what may be effect happened for this warning. Thankfully I also manage to fix this issue by installinglibxml2-utilsALL ARE TESTED UNDER UBUNTU 18.04.2 LTS
I also aware by updating README.md. Please see.
please accept my pull request and merge with the master branch