Ivan3008/homework 6 - черновик #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taksenov
reviewed
Jul 10, 2018
src/reducers/market.js
Outdated
| MOVE_ORDER_TO_FARM, | ||
| DELETE_ORDER_FROM_MARKET | ||
| } from 'actions/marketTypes'; | ||
|
|
There was a problem hiding this comment.
Нужно добавить
import { combineReducers } from 'redux';
| default: | ||
| return state; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Потребуется вот это
export default combineReducers({
orders
});
export const getMarketOrders = state => state.market.orders;
src/reducers/market.js
Outdated
| DELETE_ORDER_FROM_MARKET | ||
| } from 'actions/marketTypes'; | ||
|
|
||
| export default (state = [], action) => { |
There was a problem hiding this comment.
Перепиши эту строчку так
const orders = (state = [], action) => {
src/reducers/market.js
Outdated
| import { | ||
| CREATE_ORDER, | ||
| MOVE_ORDER_TO_FARM, | ||
| DELETE_ORDER_FROM_MARKET |
There was a problem hiding this comment.
этот экшен тебе не нужен в этом месте.
src/reducers/market.js
Outdated
| return state.filter(order => order.id !== action.payload); | ||
|
|
||
| default: | ||
| return state; |
There was a problem hiding this comment.
Код свитча сверь с этим:
switch (action.type) {
case CREATE_ORDER:
const { payload } = action;
return [...state, payload];
case MOVE_ORDER_TO_FARM:
const { id } = action.payload;
return state.filter(order => order.id !== id);
default:
return state;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.