add screenshot timeout

dexplo · Jan 30, 2025 · e9109b9 · e9109b9
1 parent fcea7fb
commit e9109b9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/dataframe_image/_pandas_accessor.py b/dataframe_image/_pandas_accessor.py
@@ -166,8 +166,7 @@ def generate_html(
         html = obj.to_html(max_rows=max_rows, max_cols=max_cols, notebook=True)
     # wrap html with a div and add id `dfi_table`
     html = f'<div id="dfi_table">{html}</div>'
-    html_template = f"""<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head><meta charset="UTF-8"/></head>{html}</html>"""
-    return html_template
+    return html
 
 
 def save_image(img_str, filename):

diff --git a/dataframe_image/converter/browser/base.py b/dataframe_image/converter/browser/base.py
@@ -68,8 +68,9 @@ def build_valid_html(self, html: str) -> str:
 
         page = f"""
         <!DOCTYPE html>
-        <html>
+        <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
         <head>
+        <meta charset="UTF-8"/>
         {css_str}
         </head>
         <body>

diff --git a/dataframe_image/converter/browser/playwright_converter.py b/dataframe_image/converter/browser/playwright_converter.py
@@ -82,7 +82,7 @@ def screenshot(self, html):
                     )
                     pass
                 page.wait_for_timeout(200)
-            screenshot_bytes = locator.screenshot()
+            screenshot_bytes = locator.screenshot(timeout=1000)
         im = Image.open(BytesIO(screenshot_bytes))
         return im
 
@@ -168,6 +168,6 @@ async def screenshot(self, html):
                     )
                     pass
                 page.wait_for_timeout(200)
-            screenshot_bytes = await locator.screenshot()
+            screenshot_bytes = await locator.screenshot(timeout=1000)
         im = Image.open(BytesIO(screenshot_bytes))
         return im