Skip to content

Commit

Permalink
block/note_block: Don't play sounds on punch. (#842)
Browse files Browse the repository at this point in the history
  • Loading branch information
mokhtarfa authored Jan 11, 2024
1 parent 21eb18f commit f392eda
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions server/block/note.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,6 @@ func (n Note) EncodeNBT() map[string]any {
return map[string]any{"note": byte(n.Pitch)}
}

// Punch ...
func (n Note) Punch(pos cube.Pos, _ cube.Face, w *world.World, _ item.User) {
if _, ok := w.Block(pos.Side(cube.FaceUp)).(Air); !ok {
return
}
n.playNote(pos, w)
}

// Activate ...
func (n Note) Activate(pos cube.Pos, _ cube.Face, w *world.World, _ item.User, _ *item.UseContext) bool {
if _, ok := w.Block(pos.Side(cube.FaceUp)).(Air); !ok {
Expand Down

1 comment on commit f392eda

@Erkam246
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually intended behaviour

As you can see in vanilla:
https://github.com/df-mc/dragonfly/assets/16340573/c9610e13-4c5b-431f-b2d5-18f52680a75b

Please sign in to comment.