player/dialogue: Basic implementation of NPC dialogues #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of a continuation from #666 however a lot of it is different.
Whilst this code works, we need a better method of implementing the
dialogueProvider
interface to allow entities such as players (often used for NPCs) to be a provider. We could just make it always implement the interface but I'm open to other ideas. There are also a few names I am not sure about, like theCanShowDialogue()
method to implement this interface.I have also decided to completely hide the idea of "opening" and "closing" buttons, they only exist in Minecraft as a way of detecting opening/closing of the menus which we can already achieve through calling
SendDialogue()
for opening and implementingdialogue.Closer
for closing.Example usage in combination with df-mc/npc where p is a
*player.Player
(modifying Player to implement dialogueProvider):