Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/winter drop #939

Closed
wants to merge 7 commits into from
Closed

Feature/winter drop #939

wants to merge 7 commits into from

Conversation

inotflying
Copy link
Contributor

@inotflying inotflying commented Nov 17, 2024 •
edited
Loading

Winter Drop

  • Creaking Heart
    • Implementation
    • Documentation
  • Pale Oak wood type
    • Implementation
    • Documentation
  • New foliage and vegetation blocks
    • Implementation
    • Documentation
  • Resin
    • Implementation
    • Documentation
  • Pale Garden biome

@celishere
Copy link

найди работу

@TwistedAsylumMC
Copy link
Member

I think it's fine to not implement creaking blocks since we do not have entity support. If you get the chance to do the other foliage/vegation then that would be appreciated!

@TwistedAsylumMC TwistedAsylumMC added the feature New feature or request label Nov 17, 2024
TwistedAsylumMC
TwistedAsylumMC requested changes Nov 17, 2024
View reviewed changes
server/block/resin_bricks.go Outdated Show resolved Hide resolved
server/block/sign.go Outdated Show resolved Hide resolved
DaPigGuy
DaPigGuy reviewed Nov 22, 2024
View reviewed changes
server/item/resin_clump.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resin clump is also a block

@inotflying inotflying changed the base branch from feature/1.21.50 to master December 4, 2024 18:04
@DaPigGuy
Copy link
Member

DaPigGuy commented Dec 15, 2024 •
edited
Loading

I've cherry-picked 566d32b, 26c6f48, and d6f3a91

@DaPigGuy
Copy link
Member

I have cherry-picked and fixed-up the remaining two commits for Resin blocks/items. The Resin Clump item has been dropped for now as it needs additional work for the block.

Thanks for the contributions!

@DaPigGuy DaPigGuy closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy left review comments

@TwistedAsylumMC TwistedAsylumMC TwistedAsylumMC requested changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inotflying @celishere @TwistedAsylumMC @DaPigGuy