fix eg status (closes #3) #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the output of `git status` changed in 1.8.5 (2556b996): the
leading core.commentChar prefix ("#" by default) was removed.
Fortunately, there's a config option to restore it
(status.displayCommentPrefix=true) and git provides
a way to set a config option while executing
a git command:
git -c name=value command --options ...
So that mostly restores the expected output.
However, there have been other changes in the output since
the status parser was last updated. There's one other
fix here — "no changes added" is now "nothing added" —
but others may be needed now and more will likely be needed
in future.
The underlying issue is that this data is being parsed
out of human-readable output rather than a machine-readable
format like that produced by git status --porcelain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
git statuschanged in 1.8.5: the leadingcore.commentCharprefix ("#" by default) was removed.Fortunately, there's a config option to restore it (
status.displayCommentPrefix=true) and git provides a way to set a config option while executing a command:So that mostly restores the expected output.
However, there have been other changes in the output since the status parser was last updated. There's one other fix here — "no changes added" is now "nothing added" — but others may be needed now and more will likely be needed in future.
The underlying issue is that this info is being parsed out of human-readable output rather than a machine-readable format like that produced by
git status --porcelain.