Fix error with new scales package that prevented charts plotting

dfe-analytical-services · Jun 19, 2024 · 8ff487e · 8ff487e
1 parent 747f8fd
commit 8ff487e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/server.R b/server.R
@@ -1424,7 +1424,7 @@ server <- function(input, output, session) {
           scale_y_continuous(labels = if (str_sub(input$splashMetric, start = -4) == "Rate" | input$splashMetric == "employmentProjection") {
             scales::percent
           } else {
-            label_number(accuracy = 1, scale_cut = cut_short_scale())
+            label_number(accuracy = 1, scale_cut = append(scales::cut_short_scale(), 1, 1))
           }) +
           labs(colour = "") +
           scale_color_manual(values = if (str_sub(input$splashMetric, start = -4) == "Rate" | str_sub(input$splashMetric, start = -10) == "population" | input$splashMetric == "employmentProjection") {
@@ -1712,7 +1712,7 @@ server <- function(input, output, session) {
             input$splashMetric == "starts") {
             scales::percent
           } else {
-            label_number(accuracy = 1, scale_cut = cut_short_scale())
+            label_number(accuracy = 1, scale_cut = append(scales::cut_short_scale(), 1, 1))
           }) +
           scale_x_discrete(
             labels = function(x) {

diff --git a/ui.R b/ui.R
@@ -588,22 +588,26 @@ width: 100%;
           div(
             class = "panel-body",
             h2("Latest update"),
-            p("17 May 2024 (1.4.0)"),
+            p("17 May 2024 (1.4.1)"),
             tags$ul(
-              tags$li("Updated the job adverts data to the latest online job adverts from Textkernel, now split by SOC2020 Sub-Major groups (previously TextKernel's own profession split was used)."),
-              tags$li("Made a correction to the achievement split by SSA to use total aims as the denominator, and the provision split to include under 19 apprenticeships and community learning in the denominator."),
-              tags$li("Add SOC codes to employment data SOC labels."),
-              tags$li("Updated cookie banner."),
-              tags$li("Updated APS employment rates, employment by industry and occupation data to the latest quarter and amended age ranges and base populations to be in line with ONS publication of this data."),
-              tags$li("Updated highest qualification data to use National Qualifications Framework allowing more recent data."),
-              tags$li("Added in highest qualification at level four plus metric."),
-              tags$li("Added a feedback survey."),
-              tags$li("Added new resources to the Further Resources tab."),
+              tags$li("Fixed package error which stopped charts plotting.")
             ),
             details(
               label = "Previous updates",
               inputId = "PreviousUpdate",
               p(
+                p("19 Jun 2024 (1.4.0)"),
+                tags$ul(
+                  tags$li("Updated the job adverts data to the latest online job adverts from Textkernel, now split by SOC2020 Sub-Major groups (previously TextKernel's own profession split was used)."),
+                  tags$li("Made a correction to the achievement split by SSA to use total aims as the denominator, and the provision split to include under 19 apprenticeships and community learning in the denominator."),
+                  tags$li("Add SOC codes to employment data SOC labels."),
+                  tags$li("Updated cookie banner."),
+                  tags$li("Updated APS employment rates, employment by industry and occupation data to the latest quarter and amended age ranges and base populations to be in line with ONS publication of this data."),
+                  tags$li("Updated highest qualification data to use National Qualifications Framework allowing more recent data."),
+                  tags$li("Added in highest qualification at level four plus metric."),
+                  tags$li("Added a feedback survey."),
+                  tags$li("Added new resources to the Further Resources tab."),
+                ),
                 p("25 March 2024 (1.3.9)"),
                 tags$ul(
                   tags$li("Calculate the bar chart splits based on percentage of the whole area (previously percentage of subgroups with data present)."),