Development #328
Merged
Development #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation
… shown for 16+ to show all employment – that’s the figure ONS and nomis tend to lead on. This may be to allign with other metrics - need to check that before changing 213 Employment volumes. For the occupation and industry figures by LADU they all look odd. I think his is because there must be suppressed figures in the volumes, then the percentages are calculated from the sum of the un-suppressed figures? Example below – it means you only get 4-5 occupations and they are so much higher than anything else. If I’ve got the reason wrong, the figures still look dubious. If there’s not an easy fix we should just remove the LADU figures entirely.
119 Employment volumes are for 16-64 year olds. This should really b…
revert to 16-64 for employment data
change publish date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Give a general description of why a change is being made, include issue number(s) being fixed if relevant
Pull request checklist
Please check if your PR fulfils the following:
run_tests_locally())tidy_code())What is the current behaviour?
Please describe the current behaviour that you are modifying, or link to a relevant issue. Include screenshots for UI changes where possible.
What is the new behaviour?
Please describe the behaviour or changes that are being added by this PR. Include screenshots for UI changes where possible.
Anything else
Add any notes for people reviewing and testing your code that are appropriate. Tag a @person to review if someone in particular needs to see this.