Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expandable function #116

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alex-rogers-hub
Copy link
Contributor

Pull request overview

Currently expandable section is very prominent and doesn't need to be expandable
...

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

Expanding

...

What is the new behaviour?

Non-expanding, more subtle

...

Anything else

Addressing issue #83

...

Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor changes to the example panel, but also please could you remove the underlying function itself from helper_functions.R.

R/ui_panels/example_tab_1.R Outdated Show resolved Hide resolved
R/ui_panels/example_tab_1.R Outdated Show resolved Hide resolved
R/ui_panels/example_tab_1.R Outdated Show resolved Hide resolved
R/ui_panels/example_tab_1.R Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants