Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/package update #125

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

rmbielby
Copy link
Contributor

@rmbielby rmbielby commented Feb 3, 2025

Pull request overview

Few bits of clean-up:

  • package updates, incl:
    • dfeshiny to bring in the latest changes we've been doing in parallel there
    • dfeR switched to CRAN version
  • Removed use of explicit £ symbols in the plotting code as they were messing up the deploy, added some explicit encoding (could be something useful to add to dfeshiny or dfeR?)
  • Switched the "Cookies" link in the footer to be "Use of cookies" in order to sidestep the conflict with input$cookies already being taken for overall cookie management.

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

Couple of out of date and broken things:

  • Spacing not turning up properly in the info tabs
  • Deploy failing due to use of £ symbols in plotting code
  • Dashboard automatically switches to cookie page

What is the new behaviour?

The dashboard no longer switches to the cookie page by default and the spacing us as we want on the info panels now.

We'll find out about the deploy once we try it.

Anything else

@rmbielby rmbielby requested a review from cjrace February 3, 2025 16:52
@rmbielby rmbielby self-assigned this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant