Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dre): Discourse client for automatic forum post management around proposals. #1098

Merged
merged 13 commits into from
Nov 21, 2024

Conversation

NikolaMilosa
Copy link
Contributor

This pull request adds an initial discourse client. The discourse client takes care of low level calls and high level coordination should be implemented into a Trait which exposes a clear api.

At the moment only the subnet replace command is changed to use the discourse api. If this was to be merged, further code changes for relevant proposal types would be added in a separate PR.

Still thinking about how to reliably test it.

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner November 21, 2024 10:27
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

rs/cli/src/commands/mod.rs Outdated Show resolved Hide resolved
@NikolaMilosa NikolaMilosa merged commit bf58041 into main Nov 21, 2024
4 checks passed
@NikolaMilosa NikolaMilosa deleted the nm-automatic-forum-post-for-proposals branch November 21, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants